-
-
Notifications
You must be signed in to change notification settings - Fork 78.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix another Sass division #34332
Fix another Sass division #34332
Conversation
@@ -29,7 +29,7 @@ | |||
@mixin make-col($size: false, $columns: $grid-columns) { | |||
@if $size { | |||
flex: 0 0 auto; | |||
width: divide(100%, divide($columns, $size)); | |||
width: percentage(divide($size, $columns)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this has been done on purpose 🤔
Getting a bit confused about this, since it was just recently changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops sorry missed your comment before I hit the merge button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I had to revert it as were started getting random percentages on our widths (e.g., instead of 75%, 75.000000019% or so). Going with this for now with the shortened precision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's as good as it gets for now!
* Fix another Sass division * Revert the percentage division in the mixins for accuracy Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Closes #34051
/cc @XhmikosR